[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

[David Majnemer via cfe-commits]

majnemer added inline comments.


================
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8795-8798
+        if (S.Diags.getDiagnosticLevel(
+                diag::warn_typecheck_vector_element_sizes_not_equal, Loc) ==
+            DiagnosticsEngine::Level::Error)
+          return QualType();
----------------
Why `return QualType()` here? Would returning `LHSType` provide confusing or incorrect diagnostics?


https://reviews.llvm.org/D24669