[PATCH] D24516: [Driver][Diagnostics] Make 'show option names' default for driver warnings

[Bruno Cardoso Lopes via cfe-commits]

bruno closed this revision.
bruno added a comment.

Committed r283827



================
Comment at: test/Driver/show-option-names.c:4
+// RUN: %clang -c -target i386-apple-darwin10 -fno-diagnostics-show-option -isysroot /FOO %s 2>&1 | FileCheck --check-prefix=CHECK-NO-SHOW-OPTION-NAMES %s
+// CHECK-NO-SHOW-OPTION-NAMES-NOT: warning: no such sysroot directory: '{{([A-Za-z]:.*)?}}/FOO' [-Wmissing-sysroot]
----------------
vsk wrote:
> vsk wrote:
> > Can you split this into two checks? One to check that the warning appear, and another to check that the option isn't printed.
> Argh, I suppose there's no "CHECK-SAME-NOT" functionality in FileCheck. If you want to shave off a compiler invocation, maybe you could write:
> 
> CHECK: ... {{$}}
The "-NOT" functionality is there, but doesn't help in this case.  The {{$}} worked well enough though! Thanks


https://reviews.llvm.org/D24516