[PATCH] D25308: [Sema] Ignore transparent_union attributes in C++

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 10 13:29:59 PDT 2016


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D25308#566176, @arphaman wrote:

> The updated patch now makes clang warn every time it encounters this attribute in C++ mode. Would that be the desired behaviour?


Yes, I believe that is the correct behavior in this instance.

The patch LGTM now, thank you!



================
Comment at: include/clang/Basic/Attr.td:1545
 //  let Subjects = SubjectList<[Record, TypedefName]>;
   let Documentation = [Undocumented];
+  let LangOpts = [COnly];
----------------
If you, or anyone else, is bored, it would be nice to document this attribute now that we're touching it. (I am not signing you up for work as part of this patch, just prodding in case you wanted to do it.)


Repository:
  rL LLVM

https://reviews.llvm.org/D25308





More information about the cfe-commits mailing list