[PATCH] D25436: [CodeCompletion] Improve completion for properties declared in Objective-C protocols

[Manman Ren via cfe-commits]

manmanren added a comment.

Thanks for working on this!
Manman



================
Comment at: lib/Sema/SemaCodeComplete.cpp:3723
     }
   } else if (!IsArrow && BaseType->getAsObjCInterfacePointerType()) {
     // Objective-C property reference.
----------------
I feel like the added logic belongs to here :] Both handle property reference.

The clause here handles ObjCObjectPointerType that is based on an ObjCInterfaceType. We need to handle the case where the base type is "id".

What do you think?


================
Comment at: lib/Sema/SemaCodeComplete.cpp:3756
     }
+  } else if (const ObjCObjectPointerType *ObjCPtr =
+                 BaseType->getAs<ObjCObjectPointerType>()) {
----------------
Can we use "auto" here?


Repository:
  rL LLVM

https://reviews.llvm.org/D25436