[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.
Eric Fiselier via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 10 06:49:16 PDT 2016
EricWF added a comment.
In https://reviews.llvm.org/D24991#566140, @sebpop wrote:
> In https://reviews.llvm.org/D24991#565861, @EricWF wrote:
>
> > Please provide benchmark tests which demonstrate that these benefits are concrete and not just "potential". Moving methods out of the dylib is no easy task so I would like hard evidence that it's worth while.
>
>
> With this patch we have seen the score of a proprietary benchmark going up by 20%, matching the performance we see with LLVM + libstdc++.
> We will provide a testcase that shows the performance uplift.
20% sounds amazing! Thanks for working on this.
Repository:
rL LLVM
https://reviews.llvm.org/D24991
More information about the cfe-commits
mailing list