[PATCH] D25008: [cmake] Split linked libraries into private & public, for linker script

[Michał Górny via cfe-commits]

mgorny marked 2 inline comments as done.
mgorny added inline comments.


================
Comment at: lib/CMakeLists.txt:86
+elseif (LIBCXX_HAS_GCC_S_LIB)
+  list(APPEND LIBCXX_LIBRARIES_PUBLIC gcc_s)
+endif()
----------------
EricWF wrote:
> I don't think `libgcc_s` should be considered a public library like `libunwind` because both Clang and GCC link it as a default system library.
However, clang doesn't add it if you use compiler-rt. In which case you are left without an unwinder.


https://reviews.llvm.org/D25008