[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

[Akira Hatanaka via cfe-commits]

ahatanak added a comment.

I have a couple of minor comments, but patch looks good to me.



================
Comment at: lib/Sema/SemaStmtAsm.cpp:141
 
+// Extracting the register name from the Expression value,
+// if there is no register name to extract, returns ""
----------------
Please remove all trailing spaces and "^M" characters in this patch. Also, run clang-format and fix indentations.


================
Comment at: lib/Sema/SemaStmtAsm.cpp:151
+      if (AsmLabelAttr *Attr = Variable->getAttr<AsmLabelAttr>())
+        return Target.isValidGCCRegisterName(Attr->getLabel())
+        ? Target.getNormalizedGCCRegisterName(Attr->getLabel(), true)
----------------
You can  just return getNormalizedGCCRegisterName() if Target.isValidGCCRegisterName() is true here.


https://reviews.llvm.org/D15075