[PATCH] D24975: [CUDA] Add #pragma clang force_cuda_host_device_{begin, end} pragmas.
Richard Smith via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 7 16:25:57 PDT 2016
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Please add a test to test/PCH for the serialization code. Otherwise, LGTM.
================
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1032
+ "force_cuda_host_device end pragma without matching "
+ "force_cuda_host_device begin.">;
} // end of Parse Issue category.
----------------
Diagnostics should not end with a period. =)
================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6701-6702
"conflicting __device__ function declared here">;
+def err_pragma_unmatched_force_cuda_host_device : Error<
+ "%0 unmatched force_cuda_host_device begin pragmas">;
def err_dynamic_var_init : Error<
----------------
This appears to be unused.
https://reviews.llvm.org/D24975
More information about the cfe-commits
mailing list