[PATCH] D25145: [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS

Marshall Clow via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 7 15:52:49 PDT 2016


mclow.lists added a comment.

Sigh. Make an expedient choice that you don't really agree with, and you get immediately reminded of it.   I suggested on an earlier review (not this patch) that I really didn't want to see `_WIN32` in any files other than `<config>`, that we should have a libc++-specific one.  I let that slide because we had a couple other instances of `_WIN32` in the source base.

About three days later, this pops up. :-(
Not your fault, but it makes me sad.


https://reviews.llvm.org/D25145





More information about the cfe-commits mailing list