[PATCH] D25225: Add an option to save the backend-produced YAML optimization record to a file

Adam Nemet via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 7 15:40:19 PDT 2016


anemet added inline comments.


================
Comment at: lib/CodeGen/CodeGenAction.cpp:198
+
+        Ctx.setDiagnosticsOutputFile(new yaml::Output(OptRecordFile->os()));
+      }
----------------
Sorry, one more thing: if PGO is available, I think we want to set Ctx.setDiagnosticHotnessRequested as well.  Without that, you'd have to pass -fsave-optimization-record and -fdiagnostics-show-hotness to get hotness info into the YAML file which feels strange.  I am certainly fine if we do this later but I wanted to bring it up since it's seems related.


https://reviews.llvm.org/D25225





More information about the cfe-commits mailing list