[PATCH] D25154: [libc++] Fix stack_allocator

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 7 15:18:39 PDT 2016


EricWF added a comment.

In https://reviews.llvm.org/D25154#564980, @STL_MSFT wrote:

> Seems plausible to me. I haven't tested this against MSVC yet, but at most I expect to have minor issues with space consumption (as we allocate helper objects and sentinel nodes, so any exactly-sized buffers may run out of room). In any event the existing stuff is totally broken, so I have no objections to you checking this in. Thanks!


Please let me know if any of your tests remain broken, so I can fix this further.


https://reviews.llvm.org/D25154





More information about the cfe-commits mailing list