[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

Artem Dergachev via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 7 07:17:54 PDT 2016


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Yay, this is great. Thanks for investigating all those loss of coverage issues!



================
Comment at: lib/StaticAnalyzer/Core/CoreEngine.cpp:610
   // Use the callee location context.
-  CallExitBegin Loc(LocCtx);
+  CallExitBegin Loc(LocCtx,RS);
 
----------------
Space after ",".


================
Comment at: lib/StaticAnalyzer/Core/CoreEngine.cpp:639
     if (N->getLocationContext()->getParent()) {
-      N = generateCallExitBeginNode(N);
+      N = generateCallExitBeginNode(N,RS);
       if (N)
----------------
Space after ",".


================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1792
 
-  Engine.enqueueEndOfFunction(Dst);
+  Engine.enqueueEndOfFunction(Dst,RS);
 }
----------------
Space after ",".


https://reviews.llvm.org/D25326





More information about the cfe-commits mailing list