[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph
Artem Dergachev via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 7 01:29:49 PDT 2016
NoQ added a comment.
In https://reviews.llvm.org/D25326#564185, @danielmarjamaki wrote:
> as I understand it the ProgramPoint when CallExitBegin is called is the same (in the exit block). do you suggest that we take the ProgramPoint for the exit block's predecessor?
CallExitBegin is //**the**// program point. I propose to make different exits from the same function be different program points. This could be achieved by adding more members to the CallExitBegin class - return statement and block count would probably be sufficient.
In fact, not sure if we need block count. If we're, say, returning from a loop with the same statement, then we're either returning different values, or returning the same literal expression, so Environment would do the job for us well in both cases.
Repository:
rL LLVM
https://reviews.llvm.org/D25326
More information about the cfe-commits
mailing list