[PATCH] D25153: preprocessor supports `-dI` flag

David Majnemer via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 6 21:32:44 PDT 2016


majnemer added a comment.

The change from an algorithmic POV looks good but I can't speak to whether or not the approach is sound, I'll leave that to @rsmith.



> majnemer wrote in PrintPreprocessedOutput.cpp:404
> !SearchPath.empty()

This review comment was never addressed.

https://reviews.llvm.org/D25153





More information about the cfe-commits mailing list