[PATCH] D25264: Implement MS _BitScan intrinsics

Albert Gutowski via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 5 13:07:35 PDT 2016


agutowski added inline comments.


> CGBuiltin.cpp:2665
> +    BasicBlock *End = createBasicBlock("bitscan_end", this->CurFn);
> +    Builder.SetInsertPoint(End);
> +    PHINode *Result = Builder.CreatePHI(ResultType, 2, "bitscan_result");

Is this line needed? I took it from __builtin_fpclassify, but I don't know what could be its purpose (it's repeated below, where the "bitscan_end" block really starts).

https://reviews.llvm.org/D25264





More information about the cfe-commits mailing list