[PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)
Nemanja Ivanovic via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 5 12:09:17 PDT 2016
OK, I get testing that I'm fine with if I remove the -O2 and the checks for
'select i1'.
Does that change suffice for the purposes of https://reviews.llvm.org/D24955
?
Namely, do I need to account for the possible addition of nsw/nuw flags to
the add instructions even without -O2?
On Wed, Oct 5, 2016 at 8:24 PM, Sanjay Patel <spatel at rotateright.com> wrote:
> spatel added a comment.
>
> In https://reviews.llvm.org/D24397#562469, @bjope wrote:
>
> > (I'm still hesitating about commiting https://reviews.llvm.org/D24955
> in llvm since that would make these clang tests fail...)
>
>
> You can't do that. Bots will send you fail mail all day as they choke on
> the clang tests - speaking from experience. :)
> We either need to fix or revert this commit in order to let
> https://reviews.llvm.org/D24955 proceed.
>
>
> Repository:
> rL LLVM
>
> https://reviews.llvm.org/D24397
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161005/6d14e385/attachment.html>
More information about the cfe-commits
mailing list