[PATCH] D25264: Implement MS _BitScan intrinsics
Reid Kleckner via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 5 09:52:49 PDT 2016
rnk added a comment.
Nice, probably ready to land with one revision.
> majnemer wrote in CGBuiltin.cpp:2640-2647
> This should be in an anonymous namespace. Also, consider using an `enum class` instead of an `enum` nested inside a namespace.
Let's also use a more specific name than MSVC, maybe MSVCIntrin or something.
https://reviews.llvm.org/D25264
More information about the cfe-commits
mailing list