[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

Eric Christopher via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 5 08:37:55 PDT 2016


echristo added a comment.

In https://reviews.llvm.org/D24644#562286, @mehdi_amini wrote:

> What about function attributes? Hey that's the trend :)
>  You could have a subset of the functions in their own sections but not all. With LTO it means that you can disable this for a single input file.


True, but we'd need data attributes too for -fdata-sections. That's the main reason I haven't migrated the options out of TargetOptions and into the IR here. Rough sketch on module merge time: We'd probably want to error on functions/data that had separate section set in one module but not in another - there are a few ways to make that not error at link time, but at that point you're really relying on weird linker side effects and it's probably not what you intended anyhow.

-eric


https://reviews.llvm.org/D24644





More information about the cfe-commits mailing list