[PATCH] D25162: Make DeletedLines local variables in checkEmptyNamespace.

Daniel Jasper via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 23:29:32 PDT 2016


djasper added a comment.

I think we should add a test for why this was a problem. IIUC, this is caused by something like:

  #if a
  #else
  #endif
  namespace {
  }

Because we actually analyze the whole thing twice.


https://reviews.llvm.org/D25162





More information about the cfe-commits mailing list