[PATCH] D25258: [coroutines] Create allocation and deallocation sub-statements.
Gor Nishanov via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 4 16:49:42 PDT 2016
GorNishanov added inline comments.
> majnemer wrote in CGCoroutine.cpp:68-69
> I think that's just `CGM.getContext().getTargetInfo().getSuitableAlign() / CGM.getContext().getTargetInfo().getCharWidth()`
Yay! One less FIXME.
I think I will make it to match __STDCPP_DEFAULT_NEW_ALIGNMENT__:
Builder.defineMacro("__STDCPP_DEFAULT_NEW_ALIGNMENT__",
Twine(TI.getNewAlign() / TI.getCharWidth()) +
TI.getTypeConstantSuffix(TI.getSizeType()));
> SemaCoroutine.cpp:570
> +
> + // Build allocation function and deallocation expressions.
> + Expr *Allocation = nullptr;
Remove 'function' from the comment to read:
// Build allocation and deallocation expressions.
https://reviews.llvm.org/D25258
More information about the cfe-commits
mailing list