[PATCH] D24598: Separate builtins for x84-64 and i386; implement __mulh and __umulh

Albert Gutowski via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 11:48:48 PDT 2016


agutowski added inline comments.


> agutowski wrote in TargetBuiltins.h:100
> Nice, thanks!
> As far as I see, it creates some inconsistency in usage of the word "last", because it's used wrong everywhere else - LastTSBuiltin is the number of the last target-specific builtin **plus one**, while LastX86CommonBuiltin doesn't have this additional one. I would leave it like that, but wanted to point that out, in case you think it's not acceptable.

Ah, now I see that LastTIBuiltin is also what its name suggests, so it's only LastTSBuiltin that's different.

https://reviews.llvm.org/D24598





More information about the cfe-commits mailing list