[PATCH] D25153: preprocessor supports `-dI` flag

[Steve O'Brien via cfe-commits]

elsteveogrande updated this revision to Diff 73518.
elsteveogrande added a comment.

- Fix a few more style nits according to LLVM style guide.
- Further fixed w/ `clang-format -style=LLVM`, kept (most of) recommended changes.
- Added more unit tests (more include cases: `#include_next`, `-imacro`)
- Drop token-to-text function; discovered `PP.getSpelling(token)`.
- Fixed an existing FIXME where we want to preserve the correct inclusion token and not use a hardcoded one.
- Clean up escape function, make safer w/r/t assumptions about buffer sizes and make parameter passing less ugly.  Improved logic, finally got simple escaping of end-of-comment sequence right after several hairbrained tries :)

Thanks for taking time to provide input @rsmith @majnemer !


https://reviews.llvm.org/D25153

Files:
  include/clang/Driver/Options.td
  include/clang/Frontend/PreprocessorOutputOptions.h
  lib/Frontend/CompilerInvocation.cpp
  lib/Frontend/PrintPreprocessedOutput.cpp
  test/Preprocessor/dump_import.h
  test/Preprocessor/dump_import.m
  test/Preprocessor/dump_include.c
  test/Preprocessor/dump_include.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25153.73518.patch
Type: text/x-patch
Size: 9613 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161004/63d438f6/attachment-0001.bin>