[PATCH] D24815: [clang] make reciprocal estimate codegen a function attribute

Sanjay Patel via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 10:49:17 PDT 2016


spatel added inline comments.


> mehdi_amini wrote in CGCall.cpp:1735
> I think I remember folks being against FMF on calls (Chris Lattner?), I'll try to find the relevant discussion.
> Otherwise your plan seems fine to me!

Yes - Chris was opposed to FMF on intrinsics (preferring parameters/metadata as the delivery mechanism instead) in 2012:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20121217/159446.html

...which you mentioned and I replied to in the post-commit thread when I added FMF to any FPMathOperator calls earlier this year:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20160104/323154.html

There were no replies to that thread on llvm-dev since my January post. I will re-post the question to llvm-dev before proceeding.

https://reviews.llvm.org/D24815





More information about the cfe-commits mailing list