[PATCH] D24933: Enable configuration files in clang
Serge Pavlov via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 4 08:08:21 PDT 2016
sepavloff added inline comments.
> mgorny wrote in driver.cpp:314
> Please document what this function does, exactly. I see you've documented it in call site but a doc here would be helpful as well.
The function is documented now.
> mgorny wrote in driver.cpp:376
> Are you sure about the name? I would rather see `TARGET-clang.cfg` than a name that doesn't explicitly mention that the file is for clang.
You are right. Changed the comment.
https://reviews.llvm.org/D24933
More information about the cfe-commits
mailing list