[PATCH] D25065: [change-namespace] Fixed a bug in getShortestQualifiedNameInNamespace.
Haojian Wu via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 4 05:38:18 PDT 2016
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
> ioeric wrote in ChangeNamespace.cpp:187
> Note that `str()` is called on `(NsName + "::")` instead of `consume_front`. But you are right, we can put the check into the while loop.
Oh, I see. Sorry for misreading the code.
https://reviews.llvm.org/D25065
More information about the cfe-commits
mailing list