[PATCH] D25204: Register Calling Convention, Clang changes

[Alexey Bataev via cfe-commits]

ABataev added a comment.

Eric, please, prepare a full context review!



> ItaniumMangle.cpp:1417-1421
> +  if (isRegCall) {
> +    Out << II->getLength() + sizeof("__regcall3__") - 1<< "__regcall3__";
> +  } else {
> +    Out << II->getLength();
> +  }

Single-line substatements must not be enclosed into braces

> ItaniumMangle.cpp:1418
> +  if (isRegCall) {
> +    Out << II->getLength() + sizeof("__regcall3__") - 1<< "__regcall3__";
> +  } else {

Line is not clang-formatted

> Mangle.cpp:70
>    const llvm::Triple &Triple = TI.getTriple();
> +
>    if (!Triple.isOSWindows() ||

Seems to me this change is not required

> MicrosoftMangle.cpp:440
>    mangleName(D);
> -  if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D))
> +  if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) 
>      mangleFunctionEncoding(FD, Context.shouldMangleDeclName(FD));

No changes here, restore original line

Repository:
  rL LLVM

https://reviews.llvm.org/D25204