[PATCH] D24933: Enable configuration files in clang

[Michał Górny via cfe-commits]

mgorny added inline comments.


> driver.cpp:314
> +
> +static llvm::cl::SearchResult findConfigFileFromProgramName(
> +    llvm::SmallVectorImpl<char> &ConfigName, StringRef ProgramName) {

Please document what this function does, exactly. I see you've documented it in call site but a doc here would be helpful as well.

> driver.cpp:376
> +  // implicitly. First try deduce configuration from executable. For instance,
> +  // file 'armv7l-clang' applies config file 'armv7l.cfg'.
> +  if (SRes == llvm::cl::SearchResult::NotSpecified) {

Are you sure about the name? I would rather see `TARGET-clang.cfg` than a name that doesn't explicitly mention that the file is for clang.

https://reviews.llvm.org/D24933