[PATCH] D21675: New ODR checker for modules

[Richard Trieu via cfe-commits]

rtrieu marked 2 inline comments as done.
rtrieu added inline comments.


> dblaikie wrote in DeclBase.cpp:1810-1812
> Inconsistent {} on single line block (in VisitEnumConstantDecl above {} are not used on a single line block) - usually drop the {} on single line blocks.
> 
> (several other instances in this patch)

These should be more consistent now.

> dblaikie wrote in first.h:5-8
> It might make this test more readable if all the types were in one file, maybe like this:
> 
>   #ifdef FIRST
>     struct S2 { friend S2Friend1 };
>   #endif
>     struct S2 { friend S2Friend2 };
>   #endif
> 
> Etc... - and it could just be a textual header that the two headers include (one header #defines/#undefs the appropriate thing and one doesn't). But maybe that's too complicated - I'm not sure.

Modified so entire test is now in one file.  The separate headers and module maps are generated into the temp folder for each run.

https://reviews.llvm.org/D21675