[PATCH] D24815: [clang] make reciprocal estimate codegen a function attribute

[Sanjay Patel via cfe-commits]

spatel added inline comments.


> mehdi_amini wrote in CGCall.cpp:1735
> I agree with getting on a path to remove these function attributes that have an equivalent on per-instruction flag.
> 
> I wonder what is the status of these flags in SelectionDAG though? We still have a variant of the flags on the TargetOptions I believe. Are all the uses migrated to per-node flags?

Good point - I think we have to convert all codegen tests that have these function-level attributes to IR FMF and make sure that the output doesn't change. Definitely not part of this patch, but hopefully something that can be done incrementally, test-by-test.

https://reviews.llvm.org/D24815