[PATCH] D25153: preprocessor supports `-dI` flag

[Steve O'Brien via cfe-commits]

elsteveogrande added a comment.

Also the other issues are old comments, now fixed with the latest updates to this.  This does now take the value of the include token: `include` or `include_once` or `import` etc.; and send that to output.

Thanks very much @rsmith !  (Sorry to have been a pest.)



> rsmith wrote in PrintPreprocessedOutput.cpp:320-321
> Do we really this? We're only using these sanitized paths within `/*...*/` comments, and generating a newline in that context seems fine. The only thing that seems necessary to escape is a `*/` within the path, which this doesn't handle.

right you are!  I was thinking of `//` when I was doing that escaping logic.

I should either escape `*/`, or even better, just use `//` for comments, is that ok?  (I feel like `//` is more robust because it'll really ignore characters until the end-of-line.)

Repository:
  rL LLVM

https://reviews.llvm.org/D25153