r283141 - [analyzer] A blind attempt to fix a buildbot after r283092.

[Hal Finkel via cfe-commits]

----- Original Message -----
> From: "Artem Dergachev" <artem at dxdy.ru>
> To: "Hal Finkel" <hfinkel at anl.gov>, "Artem Dergachev" <artem.dergachev at gmail.com>
> Cc: cfe-commits at lists.llvm.org
> Sent: Monday, October 3, 2016 3:40:02 PM
> Subject: Re: r283141 - [analyzer] A blind attempt to fix a buildbot after r283092.
> 
> 03/10/2016 23:29, Hal Finkel пишет:
> > ----- Original Message -----
> >> From: "Artem Dergachev via cfe-commits"
> >> <cfe-commits at lists.llvm.org>
> >> To: cfe-commits at lists.llvm.org
> >> Sent: Monday, October 3, 2016 3:12:13 PM
> >> Subject: r283141 - [analyzer] A blind attempt to fix a buildbot
> >> after r283092.
> >>
> >> Author: dergachev
> >> Date: Mon Oct  3 15:12:12 2016
> >> New Revision: 283141
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=283141&view=rev
> >> Log:
> >> [analyzer] A blind attempt to fix a buildbot after r283092.
> >>
> >> The msvc compiler seems to crash compiling the BugReport class.
> > When you commit a work-around like this, please add a comment
> > explaining what's going on. In this case, that we're using
> > std::vector here instead of SmallVector because using SmallVector
> > causes an ICE in MSVC version whatever (at optimization level
> > whatever).
> >
> >   -Hal
> 
> Yep, sorry, will add a comment if this actually helps; thanks for
> clarifying, i hesitated.

Thanks! It helps because, at some point, we like to get rid of these things :-)

 -Hal

> 
> >> Modified:
> >>      cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h
> >>
> >> Modified:
> >> cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h
> >> URL:
> >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h?rev=283141&r1=283140&r2=283141&view=diff
> >> ==============================================================================
> >> ---
> >> cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h
> >> (original)
> >> +++
> >> cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h
> >> Mon Oct  3 15:12:12 2016
> >> @@ -66,7 +66,7 @@ public:
> >>     typedef SmallVector<std::unique_ptr<BugReporterVisitor>, 8>
> >>     VisitorList;
> >>     typedef VisitorList::iterator visitor_iterator;
> >>     typedef SmallVector<StringRef, 2> ExtraTextList;
> >> -  typedef
> >> SmallVector<llvm::IntrusiveRefCntPtr<PathDiagnosticNotePiece>, 4>
> >> +  typedef
> >> std::vector<llvm::IntrusiveRefCntPtr<PathDiagnosticNotePiece>>
> >>         NoteList;
> >>   
> >>   protected:
> >>
> >>
> >> _______________________________________________
> >> cfe-commits mailing list
> >> cfe-commits at lists.llvm.org
> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> >>
> 
> 

-- 
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory