r283135 - Added more comments to tooling::Replacements.

Eric Liu via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 3 12:14:30 PDT 2016


Author: ioeric
Date: Mon Oct  3 14:14:30 2016
New Revision: 283135

URL: http://llvm.org/viewvc/llvm-project?rev=283135&view=rev
Log:
Added more comments to tooling::Replacements.

Summary: Also test phabricator commit processing.

Subscribers: klimek, cfe-commits

Differential Revision: https://reviews.llvm.org/D25207

Modified:
    cfe/trunk/include/clang/Tooling/Core/Replacement.h

Modified: cfe/trunk/include/clang/Tooling/Core/Replacement.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Tooling/Core/Replacement.h?rev=283135&r1=283134&r2=283135&view=diff
==============================================================================
--- cfe/trunk/include/clang/Tooling/Core/Replacement.h (original)
+++ cfe/trunk/include/clang/Tooling/Core/Replacement.h Mon Oct  3 14:14:30 2016
@@ -176,6 +176,8 @@ class Replacements {
   ///   - are insertions at the same offset and applying them in either order
   ///     has the same effect, i.e. X + Y = Y + X when inserting X and Y
   ///     respectively.
+  ///   - are identical replacements, i.e. applying the same replacement twice
+  ///     is equivalent to applying it once.
   /// Examples:
   /// 1. Replacement A(0, 0, "a") and B(0, 0, "aa") are order-independent since
   ///    applying them in either order gives replacement (0, 0, "aaa").
@@ -186,6 +188,8 @@ class Replacements {
   ///    since applying them in either order gives (0, 2, "123").
   /// 3. Replacement A(0, 3, "123") and B(2, 3, "321") are order-independent
   ///    since either order gives (0, 5, "12321").
+  /// 4. Replacement A(0, 3, "ab") and B(0, 3, "ab") are order-independent since
+  ///    applying the same replacement twice is equivalent to applying it once.
   /// Replacements with offset UINT_MAX are special - we do not detect conflicts
   /// for such replacements since users may add them intentionally as a special
   /// category of replacements.




More information about the cfe-commits mailing list