[PATCH] D24909: fix for not copying fp denormal and trapping options.

Hal Finkel via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 3 08:51:05 PDT 2016


hfinkel added a comment.

In https://reviews.llvm.org/D24909#559110, @SjoerdMeijer wrote:

> Hi Hal, 
>  Thanks for reviewing and you're right: this should work. We actually have actually some downstream (aarch64) build attribute selection code that would work better with this change. Are you okay with committing this change?
>  Cheers,
>  Sjoerd.


Can you explain what you mean? What does this code do?

My general impression is that we're planning to rip out this code entirely and reply only on setting the functions attributes. @echristo, am I right about this?


https://reviews.llvm.org/D24909





More information about the cfe-commits mailing list