[llvm-dev] Upgrading phabricator

[Sjoerd Meijer via cfe-commits]

Hi,

I just committed to Clang and noticed that the corresponding Phabricator ticket does not get automatically closed (I have "Differential Revision:" in my commit message and believe I didn't make a typo).
Is it just me, or is this is broken after the upgrade? For committing to LLVM this still seems to work.

Cheers,
Sjoerd.


-----Original Message-----
From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Alex Bradbury via llvm-dev
Sent: 30 September 2016 15:45
To: Eric Liu
Cc: llvm-dev; Clang Dev; Eric Liu via llvm-commits; cfe-commits
Subject: Re: [llvm-dev] Upgrading phabricator

On 30 September 2016 at 14:21, Eric Liu via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> Thanks for the feedback Aaron! :)
>
> I've disabled it. I think the annoying part really is the status (e.g.
> Request, Closed etc) in the tag, and I am wondering if a tag with just
> line numbers like "(N Loc)" would be better. But I'm not really sure
> about the trade-off here.

I'd suggest that [PATCH] is a waste of screen real estate too - the `Dnnnnn:` prefix makes it obvious. I do appreciate there's an argument for having it for consistency with people who post patches directly to llvm-commits.

Alex
_______________________________________________
LLVM Developers mailing list
llvm-dev at lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.