[PATCH] D25141: [libcxx] [test] Remove MSVC workarounds

[Stephan T. Lavavej via cfe-commits]

STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.

MSVC has finally fixed the compiler bug that was warning about unreferenced parameters when invoking destructors, so we can remove the void casts that were working around the bug. Yay!


https://reviews.llvm.org/D25141

Files:
  test/support/test_allocator.h


Index: test/support/test_allocator.h
===================================================================
--- test/support/test_allocator.h
+++ test/support/test_allocator.h
@@ -88,10 +88,7 @@
         {::new(static_cast<void*>(p)) T(std::forward<U>(val));}
 #endif
     void destroy(pointer p)
-        {
-            p->~T();
-            ((void)p); // Prevent MSVC's spurious unused warning
-        }
+        {p->~T();}
     friend bool operator==(const test_allocator& x, const test_allocator& y)
         {return x.data_ == y.data_;}
     friend bool operator!=(const test_allocator& x, const test_allocator& y)
@@ -291,10 +288,7 @@
 
     template<typename U, typename... Args>
     void destroy(U* p)
-    {
-        p->~U();
-        ((void)p); // Prevent MSVC's spurious unused warning
-    }
+    { p->~U(); }
 };
 
 template<typename T, typename U>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25141.73163.patch
Type: text/x-patch
Size: 861 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160930/672d8b6b/attachment.bin>