r282912 - [CUDA] Remove incorrect comment in CUDASetLambdaAttrs.

Justin Lebar via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 30 12:55:59 PDT 2016


Author: jlebar
Date: Fri Sep 30 14:55:59 2016
New Revision: 282912

URL: http://llvm.org/viewvc/llvm-project?rev=282912&view=rev
Log:
[CUDA] Remove incorrect comment in CUDASetLambdaAttrs.

I'd said that nvcc doesn't allow you to add __host__ or __device__
attributes on lambdas in all circumstances, but I believe this was user
error on my part.  I can't reproduce these warnings/errors if I pass
--expt-extended-lambda to nvcc.

Modified:
    cfe/trunk/lib/Sema/SemaCUDA.cpp

Modified: cfe/trunk/lib/Sema/SemaCUDA.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCUDA.cpp?rev=282912&r1=282911&r2=282912&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaCUDA.cpp (original)
+++ cfe/trunk/lib/Sema/SemaCUDA.cpp Fri Sep 30 14:55:59 2016
@@ -573,8 +573,4 @@ void Sema::CUDASetLambdaAttrs(CXXMethodD
     Method->addAttr(CUDADeviceAttr::CreateImplicit(Context));
     Method->addAttr(CUDAHostAttr::CreateImplicit(Context));
   }
-
-  // TODO: nvcc doesn't allow you to specify __host__ or __device__ attributes
-  // on lambdas in all contexts -- we should emit a compatibility warning where
-  // we're more permissive.
 }




More information about the cfe-commits mailing list