[PATCH] [Updated, 2, 442 lines] D23300: [analyzer] Add "Assuming..." diagnostic pieces for unsupported condition expressions.

[Artem Dergachev via cfe-commits]

NoQ updated this revision to Diff 73014.
NoQ added a comment.

- Improve the way the new piece for `if (x && y)` looks in Xcode. The "Assuming the condition is true" for `y` is now placed at the beginning of `y` rather than at the beginning of `x`, which removes the weird arrow from `y` back to `x` in Xcode.
- Fix condition is true vs condition is false error with odd number of `!`-operators within the condition (the code above was modifying the `tookTrue` variable before failing).

I'd be adding more fixes on top of this patch - in particular, i've managed to fix other issues with logical operators that were mentioned above.


https://reviews.llvm.org/D23300

Files:
  include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h
  lib/StaticAnalyzer/Core/BugReporter.cpp
  lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
  test/Analysis/DeallocUseAfterFreeErrors.m
  test/Analysis/conditional-path-notes.c
  test/Analysis/edges-new.mm
  test/Analysis/generics.m
  test/Analysis/inlining/path-notes.m
  test/Analysis/localization.m
  test/Analysis/malloc-plist.c
  test/Analysis/model-file.cpp
  test/Analysis/plist-output.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23300.73014.patch
Type: text/x-patch
Size: 143024 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160930/49f5b38c/attachment-0001.bin>