[PATCH] [Updated, 225 lines] D24864: [libcxxabi] Refactor pthread usage into a separate API

[Asiri Rathnayake via cfe-commits]

rmaprath updated this revision to Diff 73007.
rmaprath added a comment.

Updated with the following changes:

- Address review comments from @EricWF and @compnerd regarding using `_POSIX_THREADS` for detecting pthread availability. Now the patch is checking for `defined(_POSIX_THREADS) && _POSIX_THREADS >= 0` instead of enumerating the platforms.
- Fix a missed pthread dependency in `cxa_guard.cpp`. The call to `pthread_mach_thread_np` is now replaced with `__libcxxabi_thread_get_current_id()`.
- Fix a couple of missing pthread dependencies in `test_exception_storage.cpp` (see patch below).

@EricWF: Hope the new changes look OK? I'm going to test this on a Mac before committing.

I will also ping https://reviews.llvm.org/D21803 and https://reviews.llvm.org/D17815, as they'll be affected by this patch (those patches add more pthread calls).


https://reviews.llvm.org/D24864

Files:
  CMakeLists.txt
  src/config.h
  src/cxa_exception.cpp
  src/cxa_exception_storage.cpp
  src/cxa_guard.cpp
  src/fallback_malloc.ipp
  src/threading_support.h
  test/test_exception_storage.pass.cpp
  test/test_fallback_malloc.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24864.73007.patch
Type: text/x-patch
Size: 15661 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160930/c18be95e/attachment-0001.bin>