[PATCH] [Accepted] D24922: [clang-move] Make it support both relative and absolute file path arguments.

[Eric Liu via cfe-commits]

ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

Lg with nits.



> ClangMove.cpp:36
> +          llvm::sys::fs::make_absolute(InitialDirectory, AbsolutePath))
> +    llvm::errs() << "warning: could not make absolute file: '" <<  EC.message()
> +                 << '\n';

s/warning/Warning/

> ClangMove.cpp:51
> +       SM.getFileManager().getVirtualFileSystem()->makeAbsolute(AbsolutePath))
> +    llvm::errs() << "warning: could not make absolute file: '" <<  EC.message()
> +                 << '\n';

s/warning/Warning

> database_template.json:3
> +{
> +  "directory": "test_dir/build",
> +  "command": "clang++ -o test.o test_dir/test.cpp",

Maybe decorate "test_dir" as "$test_dir" or "%test_dir" or similar so that others would know it is gonna replaced.

https://reviews.llvm.org/D24922