[PATCH] [Commented On] D24986: [MS] Implement __iso_volatile loads/stores as builtins

[David Majnemer via cfe-commits]

majnemer added inline comments.


> CGBuiltin.cpp:2597-2611
> +    case ARM::BI__iso_volatile_load8:
> +    case ARM::BI__iso_volatile_load16:
> +    case ARM::BI__iso_volatile_load32:
> +    case ARM::BI__iso_volatile_load64:
> +      return RValue::get(EmitVolatileLoad(*this, E));
> +    case ARM::BI__iso_volatile_store8:
> +    case ARM::BI__iso_volatile_store16:

I think you could sink this into `EmitARMBuiltinExpr`.  You don't really need or want the fancy CGF machinery here. I'd just return the result of `CreateAlignedStore`/`CreateAlignedLoad` which should handle the `EmitTargetBuiltinExpr` issue.

https://reviews.llvm.org/D24986