[llvm-dev] Upgrading phabricator

[Eric Liu via cfe-commits]

I've switched the default email format to be plain text only now. This
option should be per-user configurable, but somehow it is not shown in the
"Settings"; I'll try if I can make the option personalized.

Regarding new features and bug fixes in this upgrade, I don't really have a
list since the Phabricator we are running is the open-source repo + some
local modification. The last merge was more than one year ago, so I guess
there should be a long list of new features and bug fixes.

Some new features that I am aware of:
- Syntax highlighting.
- Patch size in email headers
- HTML email (disabled)
- More compatible with modern arc (the reason for this upgrade)
- and more to be discovered! :)

@Mehdi Deleting unposted inline comments works for me. At which patch did
this issue occur?

- Eric

On Fri, Sep 30, 2016 at 7:39 AM Mehdi Amini <mehdi.amini at apple.com> wrote:

> One of the new “feature” is that emails are HTML only right now. Not quite
> nice for the archive (or for interacting by email).
> See for instance:
> http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160926/172081.html
>
> (Also the funky "[Changed Subscribers] “ in the title)
>
> Another issue is that we can’t delete unposted inline comment anymore.
>
> —
> Mehdi
>
> On Sep 29, 2016, at 9:35 PM, Zachary Turner via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
> You mentioned this was for an upgrade. Are there any major new features or
> bugfixes to be aware of?
> On Thu, Sep 29, 2016 at 9:26 PM Eric Liu via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
> Hi all,
>
> Phabricator is (finally) back online! Let me know if you have any feedback
> or problem :)
>
> Thanks,
> Eric
>
> On Thu, Sep 29, 2016 at 10:23 PM Eric Liu <ioeric at google.com> wrote:
>
> According to top and iotop, mysqld is still working, and the progress bar
> did move by a little bit, so I think it's just really slow. Apologies if
> this is blocking you.
>
> On Thu, Sep 29, 2016 at 10:17 PM Zachary Turner via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
> Still no word on when it will be back up?  It's not hung is it?  :D
>
> On Thu, Sep 29, 2016 at 9:03 AM mats petersson via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
> On 29 September 2016 at 16:11, Mehdi Amini via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
>
> On Sep 29, 2016, at 7:21 AM, Eric Liu via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
> Sorry for blocking everyone for so long.
>
>
> No pb, thanks very much for taking care of it :)
>
> It has been more than a year since the last upgrade, and mysql is
> adjusting schema for a table with ~150G data on a single VM instance.
>
>
> 150GB? I’m very surprised there is so much data in our phab! That seems
> huge...
>
>
> My guess is that this includes all the diffs for every revision of every
> review (as well as all the comments, etc), and it probably isn't as clever
> with diffs as for example git. Which quite soon adds up to huge numbers
> when you have tens of thousands of reviews.
>
> Purse speculation of course, I have never looked inside phabricator (or
> for that matter, any other code-review tool).
>
> --
> Mats
>
>
> —
> Mehdi
>
> Sadly, the progress bar isn't giving useful information (plus I am not a
> good system admin),  so I couldn't tell the ETA...
>
> FYI: According to previous maintainer, it takes a couple of hours for the
> last upgrade, so this should be done within a few hours (hopefully!).
>
> On Thu, Sep 29, 2016 at 4:04 PM Krzysztof Parzyszek via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
> Is there any ETA?
>
> -Krzysztof
>
> On 9/29/2016 5:34 AM, Eric Liu via llvm-dev wrote:
> > That was a bad estimation. Database upgrade is taking time.
> >
> > On Thu, Sep 29, 2016 at 11:03 AM Eric Liu <ioeric at google.com
> > <mailto:ioeric at google.com>> wrote:
> >
> >     Hi all,
> >
> >     Phabricator(reviews.llvm.org <http://reviews.llvm.org>) will be down
> >     for ~30 mins for an upgrade. Sorry for the short notice.
> >
> >     Regards,
> >     Eric
> >
> >
> >
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> >
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160930/547c5d8a/attachment-0001.html>