[PATCH] D25053: [libc++] Correct alignment condition

Shoaib Meenai via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 28 16:09:11 PDT 2016


smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.

The max alignment is a PE/COFF restriction, not an MSVC-specific
restriction; it also applies to gcc and clang when compiling for
Windows. Change the conditional to _WIN32 to reflect this.

https://reviews.llvm.org/D25053

Files:
  include/type_traits

Index: include/type_traits
===================================================================
--- include/type_traits
+++ include/type_traits
@@ -1670,10 +1670,10 @@
 _CREATE_ALIGNED_STORAGE_SPECIALIZATION(0x800);
 _CREATE_ALIGNED_STORAGE_SPECIALIZATION(0x1000);
 _CREATE_ALIGNED_STORAGE_SPECIALIZATION(0x2000);
-// MSDN says that MSVC does not support alignment beyond 8192 (=0x2000)
-#if !defined(_LIBCPP_MSVC)
+// PE/COFF does not support alignment beyond 8192 (=0x2000)
+#if !defined(_WIN32)
 _CREATE_ALIGNED_STORAGE_SPECIALIZATION(0x4000);
-#endif // !_LIBCPP_MSVC
+#endif // !_WIN32
 
 #undef _CREATE_ALIGNED_STORAGE_SPECIALIZATION
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25053.72923.patch
Type: text/x-patch
Size: 641 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160928/29af9ba9/attachment-0001.bin>


More information about the cfe-commits mailing list