[PATCH] D24946: [CUDA] Added support for CUDA-8

Artem Belevich via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 14:03:13 PDT 2016


tra marked an inline comment as done.

================
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:156
@@ +155,3 @@
+#endif
+#endif
+
----------------
jlebar wrote:
> I don't understand what we are doing here...
> 
> We're saying, if __USE_FAST_MATH__ is defined, and if it's not equal to 0, then redefine it equal to 1?  Isn't that a compile error?
Not if it happens in system headers.
That said, I can eliminate true branch of the conditional and only set those macros to 0 if they are undefined.
It will be up to whoever sets those macros to set them correctly otherwise.


https://reviews.llvm.org/D24946





More information about the cfe-commits mailing list