[PATCH] D24800: Merge conflicting replacements when they are order-independent.
Eric Liu via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 27 09:12:40 PDT 2016
ioeric added inline comments.
================
Comment at: lib/Tooling/Core/Replacement.cpp:179-181
@@ +178,5 @@
+llvm::Expected<Replacements>
+Replacements::mergeIfOrderIndependent(const Replacement &R) const {
+ Replacements Rs(R);
+ Replacements RsShiftedByReplaces(getReplacementInChangedCode(R));
+ Replacements ReplacesShiftedByRs;
----------------
klimek wrote:
> I think this is a bit subtle and needs a lot more comments to guide me along what is happening and why ...
Ahh, right! Should've done that...
Comments added.
https://reviews.llvm.org/D24800
More information about the cfe-commits
mailing list