[PATCH] D14326: ASTImporter: expressions, pt.2
Alexey Bataev via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 27 02:18:53 PDT 2016
ABataev added inline comments.
================
Comment at: lib/AST/ASTImporter.cpp:3414
@@ +3413,3 @@
+ // FriendDecl is not a NamedDecl so we cannot use localUncachedLookup.
+ CXXRecordDecl *RD = cast<CXXRecordDecl>(DC);
+ FriendDecl *ImportedFriend = RD->getFirstFriend();
----------------
CXXRecordDecl *RD -> auto *RD
================
Comment at: lib/AST/ASTImporter.cpp:5569
@@ +5568,3 @@
+ return nullptr;
+ else
+ ToTAInfo.addArgument(ToTALoc);
----------------
No need for 'else' here, unconditional statement
================
Comment at: lib/AST/ASTImporter.cpp:5583
@@ -5414,3 +5582,3 @@
FoundD,
- /*FIXME:TemplateArgs=*/nullptr);
+ /*TemplateArgs=*/ResInfo);
if (E->hadMultipleCandidates())
----------------
Remove '/*TemplateArgs=*/' comment, it is not required anymore
https://reviews.llvm.org/D14326
More information about the cfe-commits
mailing list