[PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 26 13:10:26 PDT 2016


rsmith added a comment.

Giving this the name `[[clang::suppress(...)]]` seems unhelpful. This attribute is specified by the C++ core guidelines, not by clang, and presumably we want code using this attribute to be portable across implementations of the C++ code guidelines. I'd suggest asking the editors of the core guidelines what attribute namespace they'd like used, and using that here rather than using `clang`.


https://reviews.llvm.org/D24886





More information about the cfe-commits mailing list