[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed
Dean Michael Berris via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 26 01:56:34 PDT 2016
dberris added inline comments.
================
Comment at: lib/Driver/Tools.cpp:4777-4780
@@ +4776,6 @@
+ {
+ std::string Feature(XRayInstrumentOption);
+ Feature += " on ";
+ Feature += Triple.getArchName().data();
+ D.Diag(diag::err_drv_clang_unsupported) << Feature;
+ break;
----------------
Wouldn't something like this work better:
D.Diag(...) << XRayInstrumentOption << " on " << Triple.getArchName();
https://reviews.llvm.org/D24799
More information about the cfe-commits
mailing list