[PATCH] D22968: [analyzer] A checker for macOS-specific bool- and number-like objects.

[Artem Dergachev via cfe-commits]

NoQ retitled this revision from "[analyzer] A checker for macOS-specific bool-like objects." to "[analyzer] A checker for macOS-specific bool- and number-like objects.".
NoQ updated the summary for this revision.
NoQ updated this revision to Diff 72392.
NoQ marked 10 inline comments as done.
NoQ added a comment.
Herald added subscribers: mgorny, beanz.

The checker now checks conversions of `NSNumber` to integer types, not just boolean.

To do now - a bit more time needed to test various tweaks. The current version of the non-pedantic checker has found a couple of good new true positives, being relatively silent in general. I'm keeping positives of form `x == 0` (where `x` is a number pointer) in non-pedantic checker, even though they have been reporting non-bugs, because bugs of this form have been found, and it seems very desirable to make the code more specific in this particular case.

To do later - consider conversions by passing NSNumber to a function that expects an integer, consider OSNumber and maybe CFNumber(?).


https://reviews.llvm.org/D22968

Files:
  include/clang/StaticAnalyzer/Checkers/Checkers.td
  lib/StaticAnalyzer/Checkers/CMakeLists.txt
  lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp
  test/Analysis/Inputs/system-header-simulator-objc.h
  test/Analysis/NSNumber-conversion.m
  test/Analysis/OSBoolean-conversion.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22968.72392.patch
Type: text/x-patch
Size: 18846 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160924/4d007bf8/attachment-0001.bin>