r282255 - Fix for r280064 that added options for fp denormals and exceptions.

[Renato Golin via cfe-commits]

On 23 September 2016 at 16:21, Sjoerd Meijer via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> Author: sjoerdmeijer
> Date: Fri Sep 23 10:21:33 2016
> New Revision: 282255
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282255&view=rev
> Log:
> Fix for r280064 that added options for fp denormals and exceptions.
> These options were forgotten to be copied in setCommandLineOpts.

This broke:

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-42vma/builds/12164


> +  Options.FPDenormalType =
> +    llvm::StringSwitch<llvm::FPDenormal::DenormalType>(CodeGenOpts.FPDenormalMode)
> +      .Case("ieee", llvm::FPDenormal::IEEE)
> +      .Case("preserve-sign", llvm::FPDenormal::PreserveSign)
> +      .Case("positive-zero", llvm::FPDenormal::PositiveZero);

No Default case?



> +  Options.NoTrappingFPMath = CodeGenOpts.NoTrappingMath;

This is not the same as the one above. Are you sure this patch is correct?

Has this been reviewed at all?

Please, don't commit patches at will when nothing is breaking, and put
the patch for review next time.

thanks,
--renato