[PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

[Artem Dergachev via cfe-commits]

NoQ added a comment.

Thanks, this makes a lot more sense to me!


================
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:691
@@ -690,1 +690,3 @@
 
+  // Ignore autosynthesized code.
+  if (Mgr->getAnalysisDeclContext(D)->isBodyAutosynthesized())
----------------
I think this can be moved above, to `HandleCode()`. Because not only we need to skip path-sensitive analysis for synthesized bodies, but also we should probably skip the callback for AST checkers (`runCheckersOnASTBody()`, which corresponds to `check::ASTCodeBody`), and then we should also skip the `-analyzer-display-progress` debug output (the `DisplayFunction()` thingy).


Repository:
  rL LLVM

https://reviews.llvm.org/D24792